Skip to content

Conversation

@PouyaMohseni
Copy link
Contributor

@PouyaMohseni PouyaMohseni commented Dec 12, 2025

  • count only users who verified their emails

@yinanazhou
Copy link
Member

Is there an issue about this?

@fujinaga could you please confirm if we only want to show the staff number, instead all the users, on the home page?

@PouyaMohseni
Copy link
Contributor Author

On the main page, it says Editors, so I assumed that is what we want to display, rather than the number of UMIL accounts.

@fujinaga
Copy link
Member

Is there an issue about this?

@fujinaga could you please confirm if we only want to show the staff number, instead all the users, on the home page?

So display the number of registered users and the number of editors?

@yinanazhou
Copy link
Member

In the project meeting, we mentioned that users will be divided into four categories: viewers, contributors, reviewers, etc. It would be too much information to display all of these on the home page. I think it’s better to show just the total user count instead. Displaying the total number of users also looks cleaner and better highlights the overall impact of the project. Does this make sense? @fujinaga

@fujinaga
Copy link
Member

In the project meeting, we mentioned that users will be divided into four categories: viewers, contributors, reviewers, etc. It would be too much information to display all of these on the home page. I think it’s better to show just the total user count instead. Displaying the total number of users also looks cleaner and better highlights the overall impact of the project. Does this make sense? @fujinaga

Yes.

@yinanazhou
Copy link
Member

@PouyaMohseni Could you update editors to users?

@PouyaMohseni PouyaMohseni changed the title fix: editor counts should constrain users by is_staff=True fix: count the number of users in the index page Dec 18, 2025
<div class="stat-item">
<h3 class="stat-number text-info mb-1">{{ total_editors|default:"2" }}</h3>
<p class="fs-6 mb-0">Editors</p>
<h3 class="stat-number text-info mb-1">{{ total_users|default:"10" }}</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is default set to 10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have 19 users, so I believe fallback to a larger number then 2 (number of expected editors) is more relevant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm could you update all default values to 0? that way we could know something is wrong if anything happens. Implement this in a separate commit. And please change the current commit message to fix: show all active users on home page. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants