-
Notifications
You must be signed in to change notification settings - Fork 2
fix: count the number of users in the index page #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Is there an issue about this? @fujinaga could you please confirm if we only want to show the staff number, instead all the users, on the home page? |
|
On the main page, it says |
So display the number of registered users and the number of editors? |
|
In the project meeting, we mentioned that users will be divided into four categories: viewers, contributors, reviewers, etc. It would be too much information to display all of these on the home page. I think it’s better to show just the total user count instead. Displaying the total number of users also looks cleaner and better highlights the overall impact of the project. Does this make sense? @fujinaga |
Yes. |
|
@PouyaMohseni Could you update |
2070922 to
5be4cf5
Compare
is_staff=True| <div class="stat-item"> | ||
| <h3 class="stat-number text-info mb-1">{{ total_editors|default:"2" }}</h3> | ||
| <p class="fs-6 mb-0">Editors</p> | ||
| <h3 class="stat-number text-info mb-1">{{ total_users|default:"10" }}</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is default set to 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we have 19 users, so I believe fallback to a larger number then 2 (number of expected editors) is more relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm could you update all default values to 0? that way we could know something is wrong if anything happens. Implement this in a separate commit. And please change the current commit message to fix: show all active users on home page. Thanks.
- count only useres who verified their emails
5be4cf5 to
677e9b2
Compare
Uh oh!
There was an error while loading. Please reload this page.