MEI Encoding Column Split Fix #1327
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeannaLC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: (#1323)
Fixes an issue in MEI Encoding with column splitting input where the first staff of the second column would be incorrectly marked as part of the first column. The issue was caused by the wrong
system_beginbeing updated due to an incorrect condition.The boxes were generated from an intermediate output during the job. The blue box in the first staff of the second column represents where the new column begin starts, but this should be at the last staff of the first column so the following staff is part of the second column. The condition was changed so the column begin starts right before the first note of the next column.
Rodan workflow:
Input files:
MEI Encoding Inputs.zip
Neon output:
