Skip to content

add twitter field back in#6

Open
stvnrlly wants to merge 1 commit intoDCgov:masterfrom
civictechdc:add-twitter
Open

add twitter field back in#6
stvnrlly wants to merge 1 commit intoDCgov:masterfrom
civictechdc:add-twitter

Conversation

@stvnrlly
Copy link
Copy Markdown
Collaborator

@stvnrlly stvnrlly commented Feb 5, 2016

I just realized that we dropped this. I think it's an important piece of information to keep around. I'm happy to submit a separate PR for the spec on the site if this is accepted. (As a side note: you may want to consider keeping gh-pages and master in sync since they're closely tied and edits to the schema will affect them both.)

@emanuelfeld
Copy link
Copy Markdown
Collaborator

Notion with the URL field is that it could be used with Twitter or any other site or service, but that you would give your profile's URL rather than just the username. Of course, the spec is not restrictive, but I don't know that I see the particular utility of separating out twitter from any other possible URL, especially if the URL field is going to be left blank. Thoughts?

I'll get them synced so PRs to the schema and spec can be made simultaneously.

@stvnrlly
Copy link
Copy Markdown
Collaborator Author

stvnrlly commented Feb 5, 2016

I consider URL to be for something like a contact form or about page. I think specifically mentioning Twitter encourages projects to think about the platform if they haven't already, which is useful since so much discussion goes on there. It also lets others know how they should reference the project on Twitter.

@emanuelfeld
Copy link
Copy Markdown
Collaborator

So you're saying someone wouldn't put their twitter link in the URL field? I was thinking it could be contact form, personal homepage, facebook page, twitter page. Basically whichever one the contact person/group is most responsive on.

Do you think it's important to have twitter explicit in the schema, or could it just be mentioned in the spec description and template civic.json file?

@stvnrlly
Copy link
Copy Markdown
Collaborator Author

stvnrlly commented Feb 5, 2016

I don't know; I can only speak for myself here, and I might be guided by momentum from the previous version of the standard. I personally like it in the schema since it seems like a common field that many projects should have and therefore should be in the builder. I also think that this avoids making the URL too much of a catchall field, which would require it to support an array of URLs.

@emanuelfeld
Copy link
Copy Markdown
Collaborator

Ok with waiting on this for a bit? I think we should see how people are using the new spec first.

@stvnrlly
Copy link
Copy Markdown
Collaborator Author

stvnrlly commented Feb 5, 2016

👍 That's fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants