-
Notifications
You must be signed in to change notification settings - Fork 13
More type hinting for the codebase #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More type hinting for the codebase #265
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 91.35% 91.38% +0.02%
==========================================
Files 110 110
Lines 8214 8238 +24
==========================================
+ Hits 7504 7528 +24
Misses 710 710 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@paulmueller |
|
Hey, can I change the version in the changelog and merge this? |
paulmueller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check whether numpydoc works and the API reference compiles properly when you omit the colon after the parameter name. I commented on it a few times, but you removed them in many more places.
|
OK good, then the docs render correctly without the colon. Please re-insert the info about dimensionality wherever you removed it and I will merge. |
|
Hey @paulmueller, can you please review? Especially the new section in the README. Thanks! |
paulmueller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If you have nothing else to add, I will merge!
|
Please merge! :) |

Continuing to solve the issue #198.