Skip to content

Conversation

@PinkShnack
Copy link
Contributor

@PinkShnack PinkShnack commented Nov 26, 2024

Continuing to solve the issue #198.

@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (2fe07f7) to head (10d89b6).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   91.35%   91.38%   +0.02%     
==========================================
  Files         110      110              
  Lines        8214     8238      +24     
==========================================
+ Hits         7504     7528      +24     
  Misses        710      710              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PinkShnack PinkShnack marked this pull request as draft November 26, 2024 13:18
@PinkShnack
Copy link
Contributor Author

@paulmueller
When you get a chance, please review this! I have a comment above also that I wasn't sure about.

@PinkShnack PinkShnack self-assigned this Nov 29, 2024
@PinkShnack PinkShnack marked this pull request as ready for review November 29, 2024 11:01
@PinkShnack
Copy link
Contributor Author

Hey, can I change the version in the changelog and merge this?

@PinkShnack PinkShnack mentioned this pull request Sep 17, 2025
Copy link
Member

@paulmueller paulmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether numpydoc works and the API reference compiles properly when you omit the colon after the parameter name. I commented on it a few times, but you removed them in many more places.

@PinkShnack
Copy link
Contributor Author

Regarding the docstring parameter types: imo there should either be type hints OR docstring descriptions. Otherwise, future maintenence requires changing two things for one purpose. That's why I removed the docstring parameter types after the colons. For example, when using Sphinx with autodoc_typehints = "description", then the Code (API) reference looks like this:

image

@paulmueller
Copy link
Member

OK good, then the docs render correctly without the colon. Please re-insert the info about dimensionality wherever you removed it and I will merge.

@PinkShnack
Copy link
Contributor Author

Hey @paulmueller, can you please review? Especially the new section in the README. Thanks!

Copy link
Member

@paulmueller paulmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If you have nothing else to add, I will merge!

@PinkShnack
Copy link
Contributor Author

Please merge! :)

@paulmueller paulmueller merged commit 91a690b into DC-analysis:master Sep 26, 2025
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants