Conversation
alnoki
reviewed
May 6, 2026
alnoki
reviewed
May 6, 2026
added 6 commits
May 12, 2026 18:21
- Move from a single ci.yml to per-job workflows so failures don't block unrelated checks. - test.yml: set NEXT_PUBLIC_CLUSTER for the frontend build, and exclude client + dropset-taker-bot from cargo test (mollusk-based tests rely on the bench workflow's Solana toolchain). - lint.yml: pin nightly-2026-04-15 on both the toolchain install and the cargo invocations so rustfmt resolves correctly.
cu-bench-pack-orders fails to compile under bench-program-B because `BorshBatchReplaceData::try_from_slice` needs `BorshDeserialize` in scope. Add the import gated on the borsh-derive feature.
cu-bench-tests enables `borsh-derive` on cu-bench-pack-orders without `bench-program-B`. Under that combination the import was active but the call site (gated on bench-program-B) was not, tripping clippy's unused-imports lint under `-D warnings`. Matching the import's cfg to the call site fixes it.
cargo fmt --check flagged formatting drift introduced by PR #106 once its changes landed in the PR's merge ref. Reformat the assert and remove an extra blank line so fmt --check is clean against main.
`instruction-macros-test-fixtures` uses macrotest, which shells out to `cargo expand`. Use taiki-e/install-action to install a binary release rather than building from source.
alnoki
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
CIworkflow with lint, typecheck, check, and test coverage across TypeScript and Rust.Adds a dedicated
Benchmarksworkflow that sets up Solana tooling and runs allpnpm bench:*suites.Catch regressions earlier with consistent automated checks.
Keep benchmark visibility in CI for performance-sensitive changes.