Implemented FileSystemFreeSpaceHealthCheck #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a new health check class to monitor file system free space against a configurable threshold.
Changes:
- Added
FileSystemFreeSpaceHealthCheckclass that extends Dropwizard'sHealthCheckto verify sufficient free space on a file system - Added comprehensive unit tests with mocked file system interactions to validate both healthy and unhealthy scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/nl/knaw/dans/lib/util/healthcheck/FileSystemFreeSpaceHealthCheck.java | Implements the health check logic to compare available space against required margin |
| src/test/java/nl/knaw/dans/lib/util/healthcheck/FileSystemFreeSpaceHealthCheckTest.java | Provides test coverage for both success and failure cases using mocked FileStore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
============================================
+ Coverage 46.74% 47.18% +0.44%
- Complexity 99 101 +2
============================================
Files 28 29 +1
Lines 721 729 +8
Branches 81 82 +1
============================================
+ Hits 337 344 +7
- Misses 349 350 +1
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DD-
Description of changes
How to test
Related PRs
(Add links)
*
Notify
@DANS-KNAW/core-systems