Skip to content

Conversation

@janvanmansum
Copy link
Contributor

Notify

@DANS-KNAW/core-systems

@janvanmansum janvanmansum requested a review from Copilot January 20, 2026 16:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves a dependency ready check mechanism from the dd-dataverse-ingest repository to this library, making it reusable across projects. The implementation provides a way to wait for health checks to become healthy before proceeding with application startup.

Changes:

  • Introduced DependenciesReadyCheck interface for checking dependency readiness
  • Added HealthChecksDependenciesReadyCheck implementation that polls health checks until all are healthy
  • Created DependenciesReadyCheckConfig to configure health check names and polling interval

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
DependenciesReadyCheck.java Interface defining the contract for waiting until dependencies are ready
HealthChecksDependenciesReadyCheck.java Implementation that polls configured health checks with configurable intervals
DependenciesReadyCheckConfig.java Configuration class for specifying which health checks to monitor and polling frequency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

janvanmansum and others added 2 commits January 20, 2026 17:30
…pendenciesReadyCheck.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pendenciesReadyCheck.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.19%. Comparing base (bda3efd) to head (9ee9e92).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ealthcheck/HealthChecksDependenciesReadyCheck.java 0.00% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #29      +/-   ##
============================================
- Coverage     50.29%   47.19%   -3.10%     
  Complexity       99       99              
============================================
  Files            27       28       +1     
  Lines           670      714      +44     
  Branches         75       79       +4     
============================================
  Hits            337      337              
- Misses          298      342      +44     
  Partials         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janvanmansum janvanmansum merged commit 9491994 into DANS-KNAW:master Jan 20, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant