Update user guide and documentation for v1.1.0#713
Update user guide and documentation for v1.1.0#713manuschneider wants to merge 186 commits intohaoti/doc_updatefrom
Conversation
-removed unnecessary includes -cleared up code
…rs are not the same (same behavior as Block(Fermionic)UniTensor); more information for debugging when unitttests fail
added default value to Tensor.Inv changed unittests to really test the clipping updated documentation
-small fixes for consistency and improvements of the code
-made tensor names consistent with python version
… ensure consistency with real values
…ipping -added unit tests -improved test tools on GPU -minor fixes
…n gtest on github
-removed namespace std usage -removed maxiteration value from TDVP, since it did not fix the issue on github
…seems in the main branch already
… any argument to avoid overhead of argument check; did not do this for put_block(_) for code readability
…ifier - Fix copy-paste bug: put_block_ error message incorrectly said "Use get_block_(0)" instead of "Use put_block_(0)" - Replace %d with %llu (and cast to unsigned long long) for cytnx_uint64 in all four new error messages (get_block, get_block_ x2, put_block, put_block_) to avoid undefined behavior - Apply the same two-overload pattern used by get_block/get_block_ to put_block/put_block_: no-arg fast path + idx-with-check overload that delegates to it, making the API consistent Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- tests/BlockUniTensor_test.cpp: fix loop bounds j<5 → j<11 for BUT4
second bond dim (Add, Mul, Sub, Div, Conj, Trace, Dagger, elem_exist)
- tests/gpu/BlockUniTensor_test.cpp: fix gpu_Trace 0-indexed loop body
using {j-1,k-1} → {j,k}
- tests/BlockFermionicUniTensor_test.cpp: add Transpose test covering
rowrank update, bond redirection, element preservation, and involution
- tests/DenseUniTensor_test.cpp: remove dead bond redirect loop in
Transpose_tagged (modified local copies, had no effect)
- include/UniTensor.hpp: fix typo "onces" → "ones" in Transpose docstring
- example/DMRG, example/TDVP: add comments explaining Dagger().permute_()
pattern needed after PR #725 index-order change
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- linalg test files: keep master's Check_UU_VV_Identity helper (no use)
- BlockUniTensor_test.cpp: keep 0-indexed {i,j,k,l} from our branch
- DMRG examples: keep relabels_() and set_name() calls from our branch
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace retired macos-13 runner with macos-15-intel
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.33.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.33.0) --- updated-dependencies: - dependency-name: requests dependency-version: 2.33.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…33.0 Bump requests from 2.32.3 to 2.33.0 in /docs
Bumps [setuptools](https://github.com/pypa/setuptools) from 75.8.2 to 78.1.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v75.8.2...v78.1.1) --- updated-dependencies: - dependency-name: setuptools dependency-version: 78.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pygments](https://github.com/pygments/pygments) from 2.19.1 to 2.20.0. - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.19.1...2.20.0) --- updated-dependencies: - dependency-name: pygments dependency-version: 2.20.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.3.0 to 2.6.3. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.3.0...2.6.3) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.6.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…78.1.1 Bump setuptools from 75.8.2 to 78.1.1 in /docs
Bump urllib3 from 2.3.0 to 2.6.3 in /docs
…20.0 Bump pygments from 2.19.1 to 2.20.0 in /docs
Transpose inverts the order of the indices
manuschneider
force-pushed
the
manuel/doc_update
branch
from
9e385be to
8555352
Compare
manuschneider
force-pushed
the
manuel/doc_update
branch
from
9ee34bc to
246d122
Compare
manuschneider
force-pushed
the
manuel/doc_update
branch
from
246d122 to
da8be6d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da8be6dc83
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git fetch origin ${{ github.event.pull_request.base.ref }} | ||
| git merge --no-edit origin/${{ github.event.pull_request.base.ref }} |
There was a problem hiding this comment.
This step runs git merge --no-edit, and git merge performs a commit by default (--[no-]commit perform a commit if the merge succeeds), so on runners without a preconfigured user.name/user.email it aborts with “Committer identity unknown” whenever the merge is non-fast-forward. That causes pull_request workflows to fail before tests even start; add an explicit git config user.name/user.email (or avoid creating a merge commit) before this command.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is taken over from the current master branch, which was merged into this branch. Can someone comment?
| set_target_properties(pycytnx | ||
| PROPERTIES | ||
| INSTALL_RPATH "${CMAKE_INSTALL_RPATH};${CMAKE_INSTALL_PREFIX}/lib" | ||
| ) |
There was a problem hiding this comment.
On non-macOS installs, pycytnx now only gets ${CMAKE_INSTALL_RPATH};${CMAKE_INSTALL_PREFIX}/lib, which drops the previously included ${CUTENSOR_LIBRARY_DIRS} and ${CUQUANTUM_LIBRARY_DIRS}. In builds with USE_CUTENSOR/USE_CUQUANTUM, this can leave the installed Python extension unable to locate those shared libraries at import time unless users manually export LD_LIBRARY_PATH, so the CUDA library directories (or equivalent link-path propagation) should be retained in the install RPATH.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is taken over from the current master branch, which was merged into this branch. Can someone comment?
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae00a31334
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| """ | ||
| Python-side smoke and correctness tests for UniTensor.apply() and UniTensor.apply_() | ||
| pybind bindings. |
There was a problem hiding this comment.
This new test module is added under tests/, but the CI workflow runs pytest pytests/ (see .github/workflows/ci-cmake_tests.yml), so this suite is never executed in pull requests. That means regressions in the new UniTensor.apply/apply_ Python bindings can merge undetected despite having a test file present.
Useful? React with 👍 / 👎.
| "BUILD_DOC": "OFF", | ||
| "DEV_MODE": "OFF" | ||
| "DEV_MODE": "OFF", | ||
| "CMAKE_INSTALL_PREFIX": "~/.local/cytnx" |
There was a problem hiding this comment.
Setting CMAKE_INSTALL_PREFIX to ~/.local/cytnx in a preset is unsafe because CMake cache values are not shell-expanded; the ~ is treated literally. Users invoking this preset can end up installing into an unexpected literal/relative path instead of their home directory, so this should use an explicit path (for example $env{HOME}/.local/cytnx).
Useful? React with 👍 / 👎.
8 participants
Still in progress, see #712
I would be happy about help with #596