Skip to content

removed force/check option for put_block#702

Open
manuschneider wants to merge 5 commits intomasterfrom
remove_putblock_force
Open

removed force/check option for put_block#702
manuschneider wants to merge 5 commits intomasterfrom
remove_putblock_force

Conversation

@manuschneider
Copy link
Copy Markdown
Collaborator

Fixes #501

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.52%. Comparing base (7aa7862) to head (6dc1e2a).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
include/UniTensor.hpp 15.38% 18 Missing and 4 partials ⚠️
src/UniTensor_base.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
- Coverage   35.53%   35.52%   -0.01%     
==========================================
  Files         214      214              
  Lines       33016    33022       +6     
  Branches    13133    13129       -4     
==========================================
  Hits        11731    11731              
- Misses      19361    19367       +6     
  Partials     1924     1924              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IvanaGyro
Copy link
Copy Markdown
Collaborator

This breaks Python API. I suggest deprecate the API first if we are not planning to release version 2.

@manuschneider
Copy link
Copy Markdown
Collaborator Author

This breaks Python API. I suggest deprecate the API first if we are not planning to release version 2.

Since there is no use case for this (see #501), I do not think than this option was really used.

If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated?

@IvanaGyro
Copy link
Copy Markdown
Collaborator

Since there is no use case for this (see #501), I do not think than this option was really used.

The function signature is changed. If someone use it, their code will be broken.

If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated?

You can refer how popular packages did or #672.

@manuschneider
Copy link
Copy Markdown
Collaborator Author

Since there is no use case for this (see #501), I do not think than this option was really used.

The function signature is changed. If someone use it, their code will be broken.

If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated?

You can refer how popular packages did or #672.

done

@manuschneider manuschneider added the Pending check/approval Issue fixed, and need feedback label Feb 23, 2026
@manuschneider manuschneider added Pending check/approval Issue fixed, and need feedback and removed Pending check/approval Issue fixed, and need feedback labels Mar 18, 2026
Comment thread pybind/unitensor_py.cpp Outdated
@ianmccul
Copy link
Copy Markdown
Collaborator

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38bbd295e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread include/UniTensor.hpp
Comment thread include/UniTensor.hpp
@manuschneider
Copy link
Copy Markdown
Collaborator Author

Everything resolved.

@manuschneider manuschneider requested a review from IvanaGyro April 9, 2026 13:07
@manuschneider manuschneider force-pushed the remove_putblock_force branch from 3edd614 to 6dc1e2a Compare April 10, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending check/approval Issue fixed, and need feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspicious check in UniTensor::put_block()

4 participants