removed force/check option for put_block#702
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
- Coverage 35.53% 35.52% -0.01%
==========================================
Files 214 214
Lines 33016 33022 +6
Branches 13133 13129 -4
==========================================
Hits 11731 11731
- Misses 19361 19367 +6
Partials 1924 1924 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This breaks Python API. I suggest deprecate the API first if we are not planning to release version 2. |
Since there is no use case for this (see #501), I do not think than this option was really used. If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated? |
The function signature is changed. If someone use it, their code will be broken.
You can refer how popular packages did or #672. |
done |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38bbd295e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Everything resolved. |
3edd614 to
6dc1e2a
Compare
Fixes #501