Fix item export resolution not scaling with size parameter#36
Merged
Conversation
Coverage Report for CI Build 24142281603Coverage decreased (-0.1%) to 7.568%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions32 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Copilot
AI
changed the title
[WIP] Fix item size not increasing actual image resolution
Fix item export resolution not scaling with size parameter
Apr 8, 2026
Copilot stopped work on behalf of
rubensworks due to an error
April 8, 2026 14:13
Agent-Logs-Url: https://github.com/CyclopsMC/IconExporter/sessions/6001cadd-a522-48b8-8f45-57605a0bf0eb Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
…ndowRenderState once Agent-Logs-Url: https://github.com/CyclopsMC/IconExporter/sessions/6001cadd-a522-48b8-8f45-57605a0bf0eb Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuiRenderer.prepareItemElements()uses16 * guiScalefor item atlas slot size; existing code only scaled blit position via pose matrix, not atlas resolutionwindowRenderState.guiScale = scaleImage/16before rendering each item/fluid so the atlas rebuilds atscaleImagepx resolution; use natural 16×16 GUI unit draw size (no pose scaling)newGuiScale→exportGuiScale, capturewindowRenderStateonce before loops