Open
Conversation
…ndars according to month works
…ours worked in current month, previous month and 2 months ago.
…nager as an Admin post method is used inside assignUserToManager component instead of being in separated hook
wybran
requested changes
Jun 27, 2024
| const [currentMonth, setCurrentMonth] = useState<string>('2024-06'); | ||
| const { me } = useMe(); | ||
| const { userHours } = useUserHours( | ||
| selectedUser || '074221c8-1545-4e4b-a241-60addeaa0764' |
There was a problem hiding this comment.
co to za UUID, nie powinno być czegoś takiego, parametr opcjonalny
bykowskiolaf
requested changes
Jul 1, 2024
Member
bykowskiolaf
left a comment
bykowskiolaf
left a comment
There was a problem hiding this comment.
Generalnie dobry kod. Kilka małych poprawek:
- Zmieniłbym strukture kodu, widziałem, że większość komponentów jest wrzucona do Users, fajnie to rozdzielić na te foldery gdzie jest używane
- Niektóre z palca wpisane wartości, to na pewno nie przejdzie
- React router jest po to żeby pomóc - nie przeszkadzac. Używaj więcej funkcjonalności od nich jeśli już jest w projekcie
- To samo się tyczy do react query, super, że robiłeś hooki, ale możesz je wykorzystywać w routerze
Member
There was a problem hiding this comment.
Generalnie brakowało mi podczas odpalenia
"@fullcalendar/daygrid": "^6.1.14",
"@fullcalendar/interaction": "^6.1.14",
"@fullcalendar/timegrid": "^6.1.14",
| refetch: hoursRefetch, | ||
| isLoading: hoursLoading, | ||
| isError: hoursError | ||
| } = useSuspenseQuery(hoursQueryOptions); |
Member
There was a problem hiding this comment.
Czemu nie SuspenseQuery? Router by się zajmował ładowaniem danych
| const [currentMonth, setCurrentMonth] = useState<string>('2024-06'); | ||
| const { me } = useMe(); | ||
| const { userHours } = useUserHours( | ||
| selectedUser || '074221c8-1545-4e4b-a241-60addeaa0764' |
| const calendarRef = useRef<FullCalendar | null>(null); | ||
|
|
||
| const getCurrentMonth = useCallback(() => { | ||
| if (!calendarRef.current) return '2024-06'; |
Member
There was a problem hiding this comment.
Wartości z palca to raczej średnio
| interface SelectUsersProps { | ||
| selectedUser: string | null; | ||
| setSelectedUser: ( | ||
| userId: string | null | '074221c8-1545-4e4b-a241-60addeaa0764' |
Member
There was a problem hiding this comment.
Tutaj też lipa, nie może tak być
| const { me, meLoading, meError } = useMe(); | ||
|
|
||
| if (!users) return <p>Brak użytkowników</p>; | ||
| if (meLoading) return <p>Loading...</p>; |
Member
There was a problem hiding this comment.
Do takich właśnie rzeczy jest react router i suspense query, nie trzeba sie martwic o loading
| import assignUserToManager from '@/pages/Users/components/assignUserToManager'; | ||
| import { createFileRoute } from '@tanstack/react-router'; | ||
|
|
||
| export const Route = createFileRoute('/_dashboard/assignUserToManager')({ |
Member
There was a problem hiding this comment.
Nie wiem czy potrzebna jest osobna strona do tego. Może dać to do edycji użytkownika?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.