HOTFIX: Couple of bugfixes to D3D8(LTCG) OOVPA groups#221
Merged
ergo720 merged 2 commits intoCxbx-Reloaded:masterfrom Jul 23, 2025
Merged
HOTFIX: Couple of bugfixes to D3D8(LTCG) OOVPA groups#221ergo720 merged 2 commits intoCxbx-Reloaded:masterfrom
ergo720 merged 2 commits intoCxbx-Reloaded:masterfrom
Conversation
…e_SetVertexShaderConstantNotInline(Fast)
…registers for pConstantData and ConstantCount
github-actions
Bot
added
OOVPA
ergo720
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the Cxbx-Reloaded's work in progress upstream, for updated migration changes, I started to add any missing patches I found in the process. And it got to the point where I noticed a couple of OOVPA groups are not accurate. The mistake may have been from my burnout of updating almost all OOVPA groups to include parameters and calling conventions.