Skip to content

Conversation

@RadWolfie
Copy link
Member

resolve #209

Since both GetTypeInformation functions do not have arguments stored onto the stack and coexist in at least one XDK build revision(s). Using GetTypeInformation(2) is the best solution to resolve the conflict rather than confusing the GetTypeInformation_(4|8) wording difference.

@github-actions github-actions bot added OOVPA Any OOVPA change relative needs-verification Require verification before approval XAPI OOVPA relative topic labels Jul 16, 2025
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Jul 16, 2025
@ergo720
Copy link
Member

ergo720 commented Jul 17, 2025

Could you rename them like this instead -> GetTypeInformation_4 to GetTypeInformation_1arg and GetTypeInformation_8 to GetTypeInformation_2arg? That way, someone would at least have a hint that they are resolving to the 1 and 2 argument variants respectively. Otherwise, with the proposed rename, it's not immediately obvious which is which.

@RadWolfie
Copy link
Member Author

RadWolfie commented Jul 17, 2025

Both GetTypeInformation functions use the exact name. The only difference is that the other version has additional arguments, and they're both using fastcall calling convention. Therefore, using a custom name for clarification between the two isn't ideal. However, there are already three ways to tell the difference between the two.

  1. By looking at the source code in library's OOVPA group of signatures.
  2. Call the library's API, XbSDB_Scan/XbSDB_CreateContext, with register_func argument input to receive various information such as calling convention, how many arguments, are they in registers or stack, etc.
  3. Use compiled cli tool with -e argument to include more details output.

EDIT: If one or both functions are LTCG, then they will be output as GetTypeInformation_0__LTCG_ecx1 and GetTypeInformation_0__LTCG_cl1_edx2.

@ergo720 ergo720 merged commit eef84bb into Cxbx-Reloaded:master Jul 23, 2025
13 of 14 checks passed
@RadWolfie RadWolfie deleted the xapi-fix-gettypeinfo-wording branch July 23, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OOVPA Any OOVPA change relative XAPI OOVPA relative topic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetTypeInformation_(4|8) wording bug

2 participants