Skip to content

helper: cleanup #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hinto-janai wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

helper: cleanup #511

hinto-janai wants to merge 8 commits into from

Conversation

@hinto-janai
Copy link
Member

@hinto-janai hinto-janai commented Jun 16, 2025 •
edited
Loading

What

Cleanup cuprate-helper.

There should be no logic changes, only removing and renaming.

Where

  • cuprate_helper::fs -> fs/, cuprate_fs
  • cuprate_helper::network -> cuprate_types::network
  • Remove unused code
    • helper/src/atomic.rs
    • Functions in helper/src/num.rs
    • Functions in helper/src/time.rs

@hinto-janai hinto-janai added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jun 16, 2025
@github-actions github-actions bot added A-dependency Area: Related to dependencies, or changes to a Cargo.{toml,lock} file. A-workspace Area: Changes to a root workspace file or general repo file. A-helper Area: Related to cuprate-helper. A-types Area: Related to types. labels Jun 16, 2025
hinto-janai
hinto-janai commented Jun 16, 2025
View reviewed changes
fs/src/network.rs
Comment on lines +43 to +44
/// Cuprate's arti directory.
arti_path => "arti",
Copy link
Member Author

@hinto-janai hinto-janai Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyntheticBird45 This can be used for #509.

@github-actions github-actions bot added A-p2p Area: Related to P2P. A-consensus Area: Related to consensus. A-docs Area: Related to documentation. A-storage Area: Related to storage. A-books Area: Related to Cuprate's books. A-binaries Area: Related to binaries. A-book-architecture Area: Related to the Architecture book. labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-binaries Area: Related to binaries. A-book-architecture Area: Related to the Architecture book. A-books Area: Related to Cuprate's books. A-consensus Area: Related to consensus. A-dependency Area: Related to dependencies, or changes to a Cargo.{toml,lock} file. A-docs Area: Related to documentation. A-helper Area: Related to cuprate-helper. A-p2p Area: Related to P2P. A-storage Area: Related to storage. A-types Area: Related to types. A-workspace Area: Changes to a root workspace file or general repo file. C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hinto-janai