Add a "no" config knob for dhcp6-ll-wait#349
Open
anders-nexthop wants to merge 1 commit intoCumulusNetworks:masterfrom
Open
Add a "no" config knob for dhcp6-ll-wait#349anders-nexthop wants to merge 1 commit intoCumulusNetworks:masterfrom
anders-nexthop wants to merge 1 commit intoCumulusNetworks:masterfrom
Conversation
anders-nexthop
force-pushed
the
anders-add-no-dhcp6-ll-wait-config
branch
from
cbb2b01 to
46928f6
Compare
In scenarios where we need to start dhcp6 on several interfaces at once, the mandatory 1 second sleep can add an unacceptable amount of wait time. If an operator guarantees that a link local address for a given interface will exist before we try to start dhcp6, then the wait is not necessary. Add handling for passing "no" as a value to dhcp6-ll-wait (similar to what is done for the "dhcp-wait" knob), and skip the link-local addr check when this knob is configured. Signed-off-by: Anders Linn <anders@nexthop.ai>
anders-nexthop
force-pushed
the
anders-add-no-dhcp6-ll-wait-config
branch
from
46928f6 to
e373668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scenarios where we need to start dhcp6 on several interfaces at once, the mandatory 1 second sleep can add an unacceptable amount of wait time. If an operator guarantees that a link local address for a given interface will exist before we try to start dhcp6, then the wait is not necessary. Add handling for passing "no" as a value to dhcp6-ll-wait (similar to what is done for the "dhcp-wait" knob), and skip the link-local addr check when this knob is configured.