addons: set interface mtu and alias through netlink, instead of sysfs#333
Open
christoph-heiss wants to merge 2 commits intoCumulusNetworks:masterfrom
Open
addons: set interface mtu and alias through netlink, instead of sysfs#333christoph-heiss wants to merge 2 commits intoCumulusNetworks:masterfrom
christoph-heiss wants to merge 2 commits intoCumulusNetworks:masterfrom
Conversation
The sysfs-based methods do not handle altnames at all. Instead, get/set
interface MTUs through netlink directly, which also has transparent
altname support, and is a lot more robust way in general.
At the same time, this simplifies some things as it means that the MTU
will always be present in the netlink cache.
Along the way also clean up some weird mtu_{int,str}, where the MTU is
passed around in the `address` as both string and integer.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
The sysfs-based methods do not handle altnames at all. Instead, get/set interface aliases through netlink directly, which also has transparent altname support, and is a more robust way in general. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sysfs-based methods do not handle altnames at all. Instead, get/set
interface MTUs through netlink directly, which also has transparent
altname support, and is a lot more robust way in general.
Regarding the MTU change, it also allows to clean up some
mtu_{int,str}weirdness, where the MTU is passed around in theaddressas both string and integer.