nlmanager, addons: add transparent support interface altnames#330
Open
christoph-heiss wants to merge 9 commits intoCumulusNetworks:masterfrom
Open
nlmanager, addons: add transparent support interface altnames#330christoph-heiss wants to merge 9 commits intoCumulusNetworks:masterfrom
christoph-heiss wants to merge 9 commits intoCumulusNetworks:masterfrom
Conversation
Pretty straight forward, it's just a list of the usual netlink length-type-data structure. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
This ensures that each detected link gets cached under their primary interface name as well as each respective altname. This makes lookups for either name transparent, making code using the cache easier to reason about. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
This enables transparent look-up of interfaces, enabling users of `ifaceobjdict` and `ifaceobjcurrdict` to look up interface by either name. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
This method is already inherited from the `Addon` class. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
Enables using the `bridge` addon with altnames. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
… names Enables using the `bond` addon with altnames. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
… names Enables using the `vlan` addon with altnames. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
…names Enables using the `openvswitch` addon with altnames. Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
christoph-heiss
force-pushed
the
altname-support
branch
from
1ee86a1 to
235d7d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First adds support for decoding
IFLA_PROP_LISTattributes in nlpacket viaAttributeLinkPropList.Then adds transparent handling to nlcache/ifupdownmain by caching the link reference for the primary ifname as well as for each altname of the respective interface.
nlmanager by extension itself already handles altnames well, as using
IFLA_IFNAMEin netlink requests already considers interface altnames.Finally, go through property on each addon which can take interface name(s) and add the appropriate translation there too.