Remove calls to logging.addLevelName() for existing log levels#281
Open
talber-nvidia wants to merge 1 commit intoCumulusNetworks:masterfrom
Open
Remove calls to logging.addLevelName() for existing log levels#281talber-nvidia wants to merge 1 commit intoCumulusNetworks:masterfrom
talber-nvidia wants to merge 1 commit intoCumulusNetworks:masterfrom
Conversation
Calling logging.addLevelName() for existing log levels overrides the original values in Python's logging module, which then makes it incompatible with log levels assumed by SysLogHandler. This causes unexpected behavior when using SysLogHandler, basically making it print all messages to syslog with loglevel warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling logging.addLevelName() for existing log levels overrides the original values in Python's logging module, which then makes it incompatible with log levels assumed by SysLogHandler, see
logging.handlers.SysLogHandler.priority_map.This causes unexpected behavior when using SysLogHandler, basically making it print all messages to syslog with loglevel warning.
This fixes the log level inconsistency in messages such as: