Open
Conversation
this commit goal is to improve readabilty
Setting eth as a default prefix for MGM_ITF flag make handling behave oddly, ens1 and eth1 should not have a handling diff.
Contributor
Author
|
I have updated the PR description in an effort to make it more understandable. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
I encountered an issue with VLAN interfaces based on eth* interfaces in ifupdown2. Currently, these interfaces are treated differently from other interface types, resulting in MTU discrepancies.
Consider the following configuration:
This results in the eth1.1212 MTU being 1500 instead of 2000.
Management Interface Handling:
What I understand is that interfaces prefixed with "eth" are considered Management Interfaces by ifupdown2 (these interfaces do not have MTU configured resulting in my issue).
Management interface prefixes are configurable in a policy JSON file. However, I believe that ens3 and eth1 interfaces should not have different default handling.
Proposed Changes:
Now, with this PR, "None" is being configured and allowed as the Management Interface prefix, making both ens3 and eth1 behave the same way by default.
Users can then customize their policies to handle eth-prefixed interfaces as they did before.
Additional Suggestion:
Furthermore, I think making a policy using regex might be more useful and less error-prone than a simple "startswith".