addons(ethtool): Add --set-channels option#268
Open
tomvil wants to merge 1 commit intoCumulusNetworks:masterfrom
Open
addons(ethtool): Add --set-channels option#268tomvil wants to merge 1 commit intoCumulusNetworks:masterfrom
--set-channels option#268tomvil wants to merge 1 commit intoCumulusNetworks:masterfrom
Conversation
Contributor
tomvil
commented
Jul 31, 2023
Contributor
Author
|
@julienfortin It has been a while 😄 will you merge this or should I close it? |
Contributor
|
Hi, you can leave it open. I haven't tested it yet but it looks okay. Overall i'm not a fan of if elif elif elif and the ways things are done today in the ethtool module, seems very slow to run all those commands all the time. |
Contributor
|
Hi, Interestingly enough, I did add set/get channels functions to the pyroute2 ethtool interface a few months ago: svinota/pyroute2#1192. And, as I found this PR, I was wondering why ifupdown2 is not using pyroute2 in many cases. @julienfortin , is it intentional to avoid making pyroute2 a dependency ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.