Deduplicate status and hook helpers#66
Open
snbafana wants to merge 1 commit into
Open
Conversation
7e7e167 to
5c54585
Compare
80ca558 to
3bb9e81
Compare
5c54585 to
8452f7d
Compare
3bb9e81 to
aed9e58
Compare
8452f7d to
ee78e2b
Compare
aed9e58 to
053e5a3
Compare
053e5a3 to
32e8595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dedup decision
Rechecked the status/helper owners before editing.
src/runtime/status.tsalready owns daemon status snapshots,src/runtime/menu-bar-status-cache.tsowns cache reads/writes, andsrc/runtime/hooks.tsowns hook emission. This PR only moves duplicate helper bodies into those owners; it does not redesign status snapshots or merge CLI/daemon/native models.Verification
rgfor removed local helper namespnpm typecheckpnpm check:biomepnpm test src/runtime/menu-bar-status-cache.test.ts src/runtime/hooks.test.ts src/runtime/daemon/server.test.ts src/runtime/doctor-status.test.ts src/runtime/onboarding.test.tspnpm check:app-qualitypnpm check:ci-local