Skip to content

Deduplicate status and hook helpers#66

Open
snbafana wants to merge 1 commit into
codex/cued-quality-05-native-small-cleanupfrom
codex/cued-quality-06-status-helper-dedup
Open

Deduplicate status and hook helpers#66
snbafana wants to merge 1 commit into
codex/cued-quality-05-native-small-cleanupfrom
codex/cued-quality-06-status-helper-dedup

Conversation

@snbafana

Copy link
Copy Markdown
Contributor

Summary

  • move app status metadata builders into the existing runtime status owner
  • add a snapshot-only menu-bar cache reader and use it from CLI/daemon fallbacks
  • move hook try/catch behavior behind the existing hook owner and add narrow helper tests

Dedup decision

Rechecked the status/helper owners before editing. src/runtime/status.ts already owns daemon status snapshots, src/runtime/menu-bar-status-cache.ts owns cache reads/writes, and src/runtime/hooks.ts owns hook emission. This PR only moves duplicate helper bodies into those owners; it does not redesign status snapshots or merge CLI/daemon/native models.

Verification

  • rg for removed local helper names
  • pnpm typecheck
  • pnpm check:biome
  • pnpm test src/runtime/menu-bar-status-cache.test.ts src/runtime/hooks.test.ts src/runtime/daemon/server.test.ts src/runtime/doctor-status.test.ts src/runtime/onboarding.test.ts
  • commit hook: pnpm check:app-quality
  • pre-push hook: pnpm check:ci-local

@snbafana snbafana force-pushed the codex/cued-quality-05-native-small-cleanup branch from 7e7e167 to 5c54585 Compare May 24, 2026 17:54
@snbafana snbafana force-pushed the codex/cued-quality-06-status-helper-dedup branch from 80ca558 to 3bb9e81 Compare May 24, 2026 17:56
@snbafana snbafana force-pushed the codex/cued-quality-05-native-small-cleanup branch from 5c54585 to 8452f7d Compare May 25, 2026 23:16
@snbafana snbafana force-pushed the codex/cued-quality-06-status-helper-dedup branch from 3bb9e81 to aed9e58 Compare May 25, 2026 23:17
@snbafana snbafana force-pushed the codex/cued-quality-05-native-small-cleanup branch from 8452f7d to ee78e2b Compare May 26, 2026 00:20
@snbafana snbafana force-pushed the codex/cued-quality-06-status-helper-dedup branch from aed9e58 to 053e5a3 Compare May 26, 2026 00:21
@snbafana snbafana force-pushed the codex/cued-quality-06-status-helper-dedup branch from 053e5a3 to 32e8595 Compare May 26, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant