Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Adds ML-DSA-65 (FIPS 204) signatures to the
pqcmodule via the RustCryptoml-dsacrate, following the module's existing free-function convention:pqc::ml_dsa::generate_signing_and_verification_key() -> MlDsaKeyPair— signing key serialized as its 32-byte seedpqc::ml_dsa::sign_message(message, signing_key) -> CasResult<Vec<u8>>— deterministic variant, empty contextpqc::ml_dsa::verify_signature(message, signature, verification_key) -> CasResult<bool>Errors map to existing
CasErrorvariants (InvalidKey,InvalidSignature,SigningFailed) — no changes to the FFI error-code contract.Only the ML-DSA-65 parameter set is exposed, consistent with the single parameter set exposed for ML-KEM (1024) and SLH-DSA (Shake128f). Context strings, HashML-DSA, and hedged signing are out of scope.
Testing
tests/pqc.rstests/data/ml_dsa/): 83 sign-seed vectors reproduced byte-for-byte, 203 verify vectors classified correctlyAlso includes the AES-GCM-SIV commit already on this branch, plus a small cleanup renaming two misnamed SLH-DSA tests (
hkdf_sha256_*→slh_dsa_sign_verify_*).🤖 Generated with Claude Code