docs(decompiler): Rec 35 — refine sequencing, scope the data_flow yield point (#35-3d)#237
Merged
Conversation
… point Update DECOMPILER_BUDGETS.md to reflect what has shipped (#35-1, #35-2, #35-3a, #35-3b, #35-3c) and split the data_flow yield point into its own #35-3d item, with an implementation note explaining why it is not a one-shot atomic PR the way flow_analysis was: - The data_flow fixpoint is the generic Action::perform loop, shared by every pass -- a budget tick there is not data_flow-specific without threading pass identity into the Action framework. - The ActionRestartGroup restart count is degenerate (maxrestarts = 1 in coreaction.cc's "universal" group), so a restart-count budget is useless. - "Stop data_flow early" means returning a coarser result (skip alias analysis) -- the bypass/coarser-mode semantics this doc defers to #35-4, not flow_analysis's artificial-HALT truncation. - No deterministic datatest fixture exists yet; one must force many rule applications and assert a stable partial-result header. Documentation only; no code or behaviour change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #236.
Summary
Documentation only. With
#35-3cmerged, theflow_analysishalf of#35-3is done; this refinesDECOMPILER_BUDGETS.mdto reflect that and to scope the remainingdata_flowhalf honestly.#35-1/#35-2/#35-3a/#35-3b/#35-3cdone, split thedata_flowyield point into its own#35-3drow, and add aStatuscolumn.data_flowyield point" subsection recording why#35-3dis not a one-shot atomic PR:Action::performloop (shared by every pass, not data_flow-specific);ActionRestartGrouprestart count is degenerate (maxrestarts = 1in the"universal"group);#35-4, notflow_analysis's artificial-HALT truncation;No code or behaviour change.
Test plan
[Unreleased]bullet added.Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/