Added a feature to hide notes #947
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package com.philkes.notallyx.presentation.activity.main.fragment | ||
|
|
||
| import android.os.Bundle | ||
| import android.view.View | ||
| import android.view.View.INVISIBLE | ||
| import android.view.View.VISIBLE | ||
| import android.view.WindowManager | ||
| import androidx.lifecycle.LiveData | ||
| import androidx.navigation.fragment.findNavController | ||
| import com.philkes.notallyx.R | ||
| import com.philkes.notallyx.data.model.Folder | ||
| import com.philkes.notallyx.data.model.Item | ||
| import com.philkes.notallyx.utils.security.showBiometricOrPinPromptHidden | ||
|
|
||
| open class HiddenFragment : NotallyFragment() { | ||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| super.onViewCreated(view, savedInstanceState) | ||
| model.folder.value = Folder.HIDDEN | ||
| requireActivity().window.addFlags(WindowManager.LayoutParams.FLAG_SECURE) | ||
| } | ||
|
|
||
| override fun onDestroyView() { | ||
| super.onDestroyView() | ||
| requireActivity().window.clearFlags(WindowManager.LayoutParams.FLAG_SECURE) | ||
| } | ||
|
|
||
| override fun getBackground() = R.drawable.label_off | ||
|
|
||
| override fun getObservable(): LiveData<List<Item>> { | ||
| return model.hiddenNotes!! | ||
| } | ||
|
|
||
| override fun onStart() { | ||
| super.onStart() | ||
| hide() | ||
| showBiometricOrPinPromptHidden( | ||
|
Comment on lines
+33
to
+36
Contributor
There was a problem hiding this comment. Hide the view earlier to avoid pre-auth flash of hidden content.
Suggested patch override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
- super.onViewCreated(view, savedInstanceState)
+ view.visibility = INVISIBLE
model.folder.value = Folder.HIDDEN
+ super.onViewCreated(view, savedInstanceState)
}🤖 Prompt for AI Agents |
||
| this, | ||
| R.string.hidden_lock_title, | ||
| onSuccess = { show() }, | ||
| onFailure = { findNavController().popBackStack() }, | ||
| ) | ||
|
Comment on lines
+36
to
+41
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify bypass-prone paths in LockUtils helper used by HiddenFragment.
# Expected: Identify branches where onSuccess.invoke() executes without successful authentication callback.
fd -i "LockUtils.kt" --exec nl -ba {} | sed -n '60,150p'
echo "----"
rg -n --type=kt -C3 'showBiometricOrPinPromptHidden|canAuthenticate\(|promptPinAuthentication\(|onSuccess\.invoke\('Repository: Crustack/NotallyX Length of output: 143 🏁 Script executed: #!/bin/bash
# Locate the key files
echo "=== Finding LockUtils.kt ==="
fd "LockUtils.kt" -t f
echo "=== Finding HiddenFragment.kt ==="
fd "HiddenFragment.kt" -t f
echo "=== Finding NotallyFragment.kt ==="
fd "NotallyFragment.kt" -t fRepository: Crustack/NotallyX Length of output: 412 🏁 Script executed: #!/bin/bash
# Once we locate the files, examine the LockUtils.kt showBiometricOrPinPromptHidden function
# Search for the function and surrounding code
echo "=== Searching for showBiometricOrPinPromptHidden function ==="
rg -n "showBiometricOrPinPromptHidden" --type-add 'kotlin:*.kt' -t kotlin -A 80Repository: Crustack/NotallyX Length of output: 13097 🏁 Script executed: #!/bin/bash
# Search for canAuthenticate and promptPinAuthentication patterns
echo "=== Searching for authentication helper invocations ==="
rg -n "canAuthenticate|promptPinAuthentication|onSuccess\.invoke" --type-add 'kotlin:*.kt' -t kotlin -B 2 -A 2Repository: Crustack/NotallyX Length of output: 10380 Hidden-note unlock bypassed on multiple authentication paths. In
Line 135 is the most critical: the PIN/password prompt displays but 🤖 Prompt for AI Agents |
||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| protected fun show() { | ||
| binding?.root?.visibility = VISIBLE | ||
| } | ||
|
|
||
| protected fun hide() { | ||
| binding?.root?.visibility = INVISIBLE | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.