[MPDX-9369] - Address PR feedback for Hours Per Week calculator

pages/accountLists/[accountListId]/hrTools/pdsGoalCalculator/[pdsGoalId].page.tsx

@@ -57,6 +57,7 @@ const PdsGoalCalculatorContent: React.FC<PdsGoalCalculatorContentProps> = ({
 }) => {
   const {
     rightPanelContent,
+    rightPanelTitle,
     closeRightPanel,
     calculation,
     calculationLoading,
@@ -67,7 +68,9 @@ const PdsGoalCalculatorContent: React.FC<PdsGoalCalculatorContentProps> = ({
   const rightPanel = (
     <>
       <RightPanelHeader>
-        <RightPanelTitle variant="h6">{t('Details')}</RightPanelTitle>
+        <RightPanelTitle variant="h6">
+          {rightPanelTitle ?? t('Details')}
+        </RightPanelTitle>
         <IconButton
           size="small"
           onClick={closeRightPanel}

src/components/Reports/PdsGoalCalculator/GoalsList/PdsGoalCalculations.graphql

@@ -1,3 +1,13 @@
+fragment DesignationSupportHoursItemFields on DesignationSupportHoursItem {
+  id
+  hoursPerWeek
+  numberOfWeeks
+  name
+  label
+  position
+  predefined
+}
+
 fragment PdsGoalCalculationFields on DesignationSupportCalculation {
   id
   name
@@ -19,13 +29,7 @@ fragment PdsGoalCalculationFields on DesignationSupportCalculation {
   ministryTravelMeals
   otherAnnualReimbursements
   designationSupportHoursItems {
-    id
-    hoursPerWeek
-    numberOfWeeks
-    name
-    label
-    position
-    predefined
+    ...DesignationSupportHoursItemFields
   }
 }
 
@@ -78,13 +82,7 @@ mutation CreateDesignationSupportHoursItem(
 ) {
   createDesignationSupportHoursItem(input: { attributes: $attributes }) {
     designationSupportHoursItem {
-      id
-      hoursPerWeek
-      numberOfWeeks
-      name
-      label
-      position
-      predefined
+      ...DesignationSupportHoursItemFields
     }
   }
 }
@@ -94,13 +92,7 @@ mutation UpdateDesignationSupportHoursItem(
 ) {
   updateDesignationSupportHoursItem(input: { attributes: $attributes }) {
     designationSupportHoursItem {
-      id
-      hoursPerWeek
-      numberOfWeeks
-      name
-      label
-      position
-      predefined
+      ...DesignationSupportHoursItemFields
     }
   }
 }

src/components/Reports/PdsGoalCalculator/Setup/HoursPerWeekGrid/HoursPerWeekGrid.test.tsx

@@ -63,7 +63,6 @@ describe('HoursPerWeekGrid', () => {
       </PdsGoalCalculatorTestWrapper>,
     );
 
-    expect(await findByText('Hours Per Week Calculator')).toBeInTheDocument();
     await waitForDataToLoad();
     expect(await findByText('Regular Week')).toBeInTheDocument();
     expect(getByText('Travel')).toBeInTheDocument();