Skip to content

Conversation

@zweatshirt
Copy link
Contributor

@zweatshirt zweatshirt commented Jan 14, 2026

Description

  • Adds a cancel button on all steps except the Receipt.
  • Cancellation deletes the mutation, since the intended result is to completely cancel the request altogether.

Jira ticket

Testing

  • Go to reports/salaryRequest > Create new calculation or continue calculation
  • Ensure that the Cancel button appears on all form steps except the receipt step.
  • Check that the cancellation button successfully deletes the request.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@zweatshirt zweatshirt self-assigned this Jan 14, 2026
@zweatshirt zweatshirt added the Preview Environment Add this label to create an Amplify Preview label Jan 14, 2026
@github-actions
Copy link
Contributor

Preview branch generated at https://MPDX-9211.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 3e01774

No significant changes found

@zweatshirt zweatshirt marked this pull request as ready for review January 14, 2026 23:40
@zweatshirt zweatshirt requested a review from canac January 14, 2026 23:41
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works and looks great! I reached out to Joanna in Figma for clarity on whether cancel should delete the request. Can you wait to merge until we hear back?

variant="text"
onClick={() => setRemoveDialogOpen(true)}
color="error"
disabled={!calculation?.id}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the early return, I don't think calculation?.id can ever be falsy.

Suggested change
disabled={!calculation?.id}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants