-
Notifications
You must be signed in to change notification settings - Fork 35
chore(deps): bump the npm_and_yarn group across 5 directories with 3 updates #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "@crossmint/common-sdk-base": "workspace:*", | ||
| "@datadog/browser-logs": "6.24.1", | ||
| "exponential-backoff": "3.1.1", | ||
| "uuid": "9.0.1", | ||
| "uuid": "14.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This bumps
No direct Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/client/base/package.json
Line: 27
Comment:
**Large `uuid` major version jump with several breaking changes**
This bumps `uuid` from `9.0.1` to `14.0.0`, spanning five major releases. Key breaking changes across the skipped versions:
- **v12**: CommonJS support was removed — the package is now ESM-only. Any consumer using `require('uuid')` or a bundler configured for CJS will break.
- **v13**: Browser exports became the default, which changes module resolution for Node.js consumers unless they explicitly use the `node` condition.
- **v14**: Node.js ≥20 is now required; `crypto` must be globally available. If the project or its consumers run on Node 18, `uuid` will throw at runtime.
No direct `import ... from 'uuid'` was found in `packages/client/base/src`, so the impact may be limited — but please verify whether any downstream consumer of this package imports `uuid` via CommonJS or runs on Node 18.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "zod": "3.22.4" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pnpm-lock.yamlshows thatapps/wallets/reactwas previously resolvingnext@16.2.3(from specifier^16.2.3). This PR changes the constraint to^15.5.18, which is a major version downgrade. If any Next.js 16 APIs or features are used in this app, they would break silently at runtime. Please confirm this is intentional and that the app has been tested against Next.js 15.Prompt To Fix With AI