-
Notifications
You must be signed in to change notification settings - Fork 34
chore(deps): bump the npm_and_yarn group across 6 directories with 5 updates #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "@crossmint/common-sdk-base": "workspace:*", | ||
| "@datadog/browser-logs": "6.24.1", | ||
| "exponential-backoff": "3.1.1", | ||
| "uuid": "9.0.1", | ||
| "uuid": "14.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/client/base/package.json
Line: 27
Comment:
**uuid 14 drops Node 18 support and requires global `crypto`**
`uuid@14` dropped Node 18 support and now expects `crypto` to be globally available (Node 20+). Since `@crossmint/client-sdk-base` is a published SDK consumed by server-side environments, any consumer still on Node 18 will receive a runtime error when uuid attempts to access the global `crypto` object. Consider verifying the minimum Node version enforced across consumer environments before shipping this.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "zod": "3.22.4" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file previously pinned
"next": "^16.2.3"and the change lowers it to^15.5.18. Every other app in the repo moves from 15.5.15 → 15.5.18, but this one moves backward from a 16.x range. If the application was already running (or testing against) Next.js 16, reverting to 15.x could reintroduce bugs or remove features that were being relied upon.Prompt To Fix With AI