-
Notifications
You must be signed in to change notification settings - Fork 34
chore(deps): bump the npm_and_yarn group across 6 directories with 4 updates #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "@crossmint/common-sdk-base": "workspace:*", | ||
| "@datadog/browser-logs": "6.24.1", | ||
| "exponential-backoff": "3.1.1", | ||
| "uuid": "9.0.1", | ||
| "uuid": "14.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This is a 5-major-version jump. Three breaking changes could affect this package at runtime:
Please verify that all deployment environments are on Node 20+, that no CJS consumers of this package rely on Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/client/base/package.json
Line: 27
Comment:
**uuid 9→14: multiple breaking changes require verification**
This is a 5-major-version jump. Three breaking changes could affect this package at runtime:
- **CommonJS removed** (v12): if any consumer imports `uuid` via `require()` or if bundler config emits CJS, imports will fail.
- **Node 20+ required** (v14): `crypto` must be globally available; Node 18 environments will throw at runtime.
- **Browser exports now default** (v13): the resolution strategy changed, which may silently affect SSR paths.
Please verify that all deployment environments are on Node 20+, that no CJS consumers of this package rely on `require('uuid')`, and that SSR usage still resolves correctly after the export-map change.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "zod": "3.22.4" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nextrange changed from^16.2.3to^15.5.18The previous range
^16.2.3referenced a Next.js version that does not appear to exist, so this is likely a correction. The change is safe, but worth confirming intentionally: the app will now resolve to 15.x rather than any hypothetical 16.x release. If the intent was to track a future major, the team should be aware the range now pins to 15.Prompt To Fix With AI