-
Notifications
You must be signed in to change notification settings - Fork 35
chore(deps): bump the npm_and_yarn group across 5 directories with 5 updates #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "@crossmint/common-sdk-base": "workspace:*", | ||
| "@datadog/browser-logs": "6.24.1", | ||
| "exponential-backoff": "3.1.1", | ||
| "uuid": "9.0.1", | ||
| "uuid": "14.0.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/client/base/package.json
Line: 27
Comment:
**`uuid` v14 requires Node.js 20+ and removes CJS support**
`uuid` v14 drops Node.js 18 support and `uuid` v12 removed CommonJS entirely. The package exports a CJS artifact (`"require": "./dist/index.cjs"` and `"main": "./dist/index.cjs"`), which means any consumer loading the CJS bundle will attempt to `require('uuid')`. If the bundler (tsup) does not inline `uuid` into the CJS output, this will fail at runtime on environments still using CJS imports or Node.js 18. Additionally, searching the source tree reveals `uuid` is not directly imported anywhere under `packages/client/base/src` — worth verifying whether this dependency is still needed at all.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "zod": "3.22.4" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viteis bumped from^5.1.0to^6.4.2, which is a breaking major version change. Vite 6 introduced the new Environment API and several breaking changes that affect plugins, SSR configuration, and module resolution behavior. Please verify the Remix app'svite.config.tsis compatible with Vite 6 (check plugin API changes,resolve.conditionsdefaults, and any usage of the legacy CJS Node.js API).Prompt To Fix With AI