Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/auth/remix-ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"postcss": "^8.4.38",
"postcss": "^8.5.10",
"tailwindcss": "^3.4.4",
"typescript": "^5.1.6",
"vite": "^5.1.0",
"vite": "^6.4.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Vite 5 → 6 major-version bump with Remix 2

vite is being jumped from ^5.1.0 to ^6.4.2 while @remix-run/dev remains at ^2.16.8. Vite 6 is a breaking-change release (changed resolve.conditions defaults, dropped some Node.js API compatibility, etc.). Remix v2 introduced Vite support targeting Vite 5; please confirm that @remix-run/dev@2.16.8 declares Vite 6 in its peer dependency range before merging, otherwise the dev and build pipeline for this app may break.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/auth/remix-ssr/package.json
Line: 38

Comment:
**Vite 5 → 6 major-version bump with Remix 2**

`vite` is being jumped from `^5.1.0` to `^6.4.2` while `@remix-run/dev` remains at `^2.16.8`. Vite 6 is a breaking-change release (changed `resolve.conditions` defaults, dropped some Node.js API compatibility, etc.). Remix v2 introduced Vite support targeting Vite 5; please confirm that `@remix-run/dev@2.16.8` declares Vite 6 in its peer dependency range before merging, otherwise the dev and build pipeline for this app may break.

How can I resolve this? If you propose a fix, please make it concise.

"vite-tsconfig-paths": "^4.2.1"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"jest": "29.6.4",
"rimraf": "6.0.1",
"ts-jest": "29.1.1",
"tsup": "8.1.0",
"tsup": "8.3.5",
"turbo": "2.2.3",
"typescript": "5.5.3",
"vitest": "1.6.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/client/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@crossmint/common-sdk-base": "workspace:*",
"@datadog/browser-logs": "6.24.1",
"exponential-backoff": "3.1.1",
"uuid": "9.0.1",
"uuid": "14.0.0",
"zod": "3.22.4"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/client/wallets/walletconnect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@types/react": "^18.3.0",
"@types/react-dom": "^18.3.0",
"autoprefixer": "10.4.17",
"postcss": "8.4.35",
"postcss": "8.5.10",
"react": "^18.3.0",
"react-dom": "^18.3.0",
"tailwindcss": "3.4.1"
Expand Down
Loading
Loading