Prevent double-free error and fix wait time bug when watchdog restarts BufferedCapture #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… watchdog restarts BufferedCapture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing resources after a camera disconnect, there was a potential double-free error caused by manually calling unref() on the GStreamer pipeline while Python's garbage collector also attempts to release it. This PR removes the manual unref() and relies on Python GC only.
Additionally, when the watchdog restarts BufferedCapture after a crash or hang, in standard mode the remaining capture duration was not recomputed - capture would restart for the full night duration instead of just the remainder. This PR recomputes the remaining time until sunrise after a restart.