Make eventmonitor logging aware of different start times for continuous capture vs night time only capture #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested and working on au000a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to issue #669
After an eventmonitor run, one of the last log messages is the next start time, and if it is within the next 2 hours, the number of minutes before the start.
This was added because EventMonitor logging was causing the original capture start log message to scroll off the console.
Now the continuous capture has a different start time to night time only capture, this logging will be incorrect if continuous capture was selected.
This PR corrects this error.
However, since continuous capture causes these log messages to scroll off the screen anyway, the neatest solution might be to get rid of these log messages when continuous capture is selected, and simplify the code.
I do think that the continuous capture start time and the night time capture start time could all be rolled into the existing captureDuration, with a keyword parameter.