Added simple error flag to handle packet issues.

[Shal-Ziar]

Made use of C++ internal check for correct packet size.
Now uses a simple flag to check if packet length error has been triggered, if so -> runtime error.

Should fix decoding issues, or at least will allow Python side error capturing.
This Issue

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ifsnop]

Are you sure that best option is to abort execution? Couldn't the parser recover after this error? El mié, 26 mar 2025, 14:17, M de Vries ***@***.***> escribió:

…

Made use of C++ internal check for correct packet size. Now uses a simple flag to check if packet length error has been triggered, if so -> runtime error. Should fix decoding issues, or at least will allow Python side error capturing. ------------------------------ You can view, comment on, or merge this pull request online at: #237 Commit Summary - 2acab14 <2acab14> Added simple error flag to handle packet issues. File Changes (7 files <https://github.com/CroatiaControlLtd/asterix/pull/237/files>) - *A* .vscode/launch.json <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-bd5430ee7c51dc892a67b3f2829d1f5b6d223f0fd48b82322cfd45baf9f5e945> (37) - *A* asterix/test/test_cat62error.py <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-3b3dc4690d5b2ee900f9cbbf2e0a0c2d6fb08daded441ba0cde3ce0da625738a> (13) - *M* asterix_decoder.egg-info/PKG-INFO <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-7369068966609993a2f2758a889cfb44ea5168e1255022e43de0159d3db6e73e> (17) - *M* asterix_decoder.egg-info/SOURCES.txt <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-54a1a424b67ff51ffc6a71532d15973121fa4cdd41f48127c96686676a6e0ac8> (12) - *M* src/asterix/InputParser.cpp <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-d4c280a481aca32ee315ca52cc036e8dad697c799d00b77bf4d936836d3ac316> (1) - *M* src/asterix/InputParser.h <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-57d836edda2014c552dc9deb51d35499ddfe9bb701a5571768e7863eeba59ef5> (5) - *M* src/python/python_parser.cpp <https://github.com/CroatiaControlLtd/asterix/pull/237/files#diff-bed3ecb8306b708dce3c308ea49e8926e24c1ef8365a9af2446dfed0efbed786> (5) Patch Links: - https://github.com/CroatiaControlLtd/asterix/pull/237.patch - https://github.com/CroatiaControlLtd/asterix/pull/237.diff — Reply to this email directly, view it on GitHub <#237>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHMH2ACCE37NSNOQHIXSDD2WKLD7AVCNFSM6AAAAABZ2JCQU6VHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DSNJXHEZDQNI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Shal-Ziar]

No, it probably isn't. But honestly C++ isn't my forte, so this is the best that I could come up with.
Probably there's a better and neater way to deal with this. Probably using the checksum of the packet, but in the short-term it's better than crashing the code imho.

I'd thus rather view it as a mitigation as opposed to a solution. Now the user can at least catch the error from the Python side and continue operation (or not).