Skip to content

Store product name in database as is if not match with a key in settings.ini #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crinibus merged 2 commits into from
Jan 29, 2025
Merged

Store product name in database as is if not match with a key in settings.ini #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff952fa
Update method 'get_user_product_name' - compare product name with ele…
Crinibus Jan 26, 2025
562fa6e
Update method 'get_product_info' - don't lowercase raw product name
Crinibus Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scraper/domains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_product_info(self) -> Info:
self._request_product_data()
self._get_common_data()
raw_name = self._get_product_name()
name = Config.get_user_product_name(raw_name.lower())
name = Config.get_user_product_name(raw_name)
price = self._get_product_price()
currency = self._get_product_currency()
id = self._get_product_id()
Expand Down
3 changes: 2 additions & 1 deletion scraper/filemanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,13 @@ def get_request_timeout() -> float | None:

@staticmethod
def get_user_product_name(product_name: str) -> str:
product_name_lowercase = product_name.lower()
user_product_names = Config.get_section_by_name("ChangeName")

for key in Config.get_key_values(user_product_names):
key_list = user_product_names[key].split(",")
value_key = f'value{key.strip("key")}'
if all(elem in product_name for elem in key_list):
if all(elem.lower() in product_name_lowercase for elem in key_list):
return user_product_names[value_key]

return product_name
Loading