fix(pumps): use rpm/watts to determine running state instead of command==10#61
Open
celestinjr wants to merge 1 commit intoCrewski:mainfrom
Open
fix(pumps): use rpm/watts to determine running state instead of command==10#61celestinjr wants to merge 1 commit intoCrewski:mainfrom
celestinjr wants to merge 1 commit intoCrewski:mainfrom
Conversation
…nd==10 PumpOnSensor relied on command==10 to determine if a pump is running. This is incorrect for Regal Modbus pumps, which emit command=4 while actively running (e.g. rpm=3450, watts=1406, command=4), causing the running state sensor to incorrectly toggle off/on with each state update. Fix: for non-relay pumps, use rpm>0 or watts>0 as the running indicator. Relay-based pumps retain existing relay>0 logic. Aligns with the same fix applied in nodejs-poolController-dashPanel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PumpOnSensor relied on
command == 10to determine if a pump is running.This is incorrect for Regal Modbus pumps, which emit
command=4whileactively running (e.g., rpm=3450, watts=1406, command=4), causing the
running state sensor to incorrectly toggle off/on with each state update.
Solution
For non-relay pumps, use
rpm > 0orwatts > 0as the running indicator.These fields are always present and accurate regardless of pump protocol.
Relay-based pumps retain existing
relay > 0logic.Testing