Fix 6 critical bugs: unique_id, auth, location selection, token retry, coordinator, device IDs#19
Open
j2deen wants to merge 1 commit intoCrewski:mainfrom
Open
Fix 6 critical bugs: unique_id, auth, location selection, token retry, coordinator, device IDs#19j2deen wants to merge 1 commit intoCrewski:mainfrom
j2deen wants to merge 1 commit intoCrewski:mainfrom
Conversation
… token retry, coordinator errors, device identifiers - config_flow: Convert deviceid to str for unique_id (fixes Crewski#18) - config_flow: Add try/except around pumpspy.setup() with user-facing error messages (fixes Crewski#14, Crewski#15) - config_flow: Use user-selected location instead of always locations[0] (fixes Crewski#12) - pypumpspy: Retry fetch_data with fresh session after token refresh instead of breaking with empty data - __init__: Raise UpdateFailed instead of silently returning None from _async_update_data - entity: Convert deviceid to str in device identifiers - Bump version to 0.1.5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deviceidtostrforunique_id— HA requires string, API returns int (fixes Pumpspy (Basement Sump Pump) from integration pumpspy_ha has an invalid unique_id #18)pumpspy.setup()with user-facing error messages instead of unhandled crash (fixes After 24.4.2 installed, PumpSpy won't initialize on restart #14, Cant login - error #15)locations[0](fixes Issue when you have devices at 2 locations on the same account #12)fetch_datawith fresh session after token refresh instead of breaking out of loop with empty dataUpdateFailedinstead of silently returningNonefrom_async_update_data, which caused all sensors to crashdeviceidtostrin device identifiersTest plan
unique_idwarning no longer appears in HA logs🤖 Generated with Claude Code