Add align Wheel property for top/center/bottom vertical alignment#57
Add align Wheel property for top/center/bottom vertical alignment#57DankTechnologies wants to merge 1 commit intoCrazyTim:mainfrom
align Wheel property for top/center/bottom vertical alignment#57Conversation
…ithin the container
|
Hey @DankTechnologies thanks for the PR! I have a few thoughts about this, but first can you help me understand why its needed? The more detail you can share the better. Perhaps could you share a few examples where it would be useful? It seems like a really good idea, but I'm just not sure if this feature should be extended to support the horizontal axis as well, or how it should interact with Any detail and examples you can share will be helpful to get this merged! Thanks! |
|
Sure thing, appreciate the feedback. Here's a minimal example
The goal is to make the wheel as big as possible, less some padding. The results are the same on desktop viewports, but when you adjust to mobile/potrait, the baseline behavior centers the wheel and the space above/below grows significantly. I'm trying to overlay a SVG pointer guy in the top left, and aligning the wheel to the top of the wheel-container div made that much easier to accomplish. Picture on my current jank attached
I agree with the feedback re:horizontal support. I mulled naming this
|

This change adds an
alignWheel property to control vertical alignment - top, center, bottom.centeris the default to ensure no breaking changes.topis helpful on mobile for better control when using separate DOM elements as the pointer, in terms of positioning and stacking.Great library!