Bring back the Derived Type Discriminator Convention for MongoDB#1869
Merged
Bring back the Derived Type Discriminator Convention for MongoDB#1869
Conversation
Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Restore derived type serializer for MongoDB
Bring back the Derived Type Discriminator Convention for MongoDB
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-introduces the
DerivedTypeDiscriminatorConventionthat was accidentally dropped during repository migration. This convention enables MongoDB to correctly serialize and deserialize polymorphic types decorated withDerivedTypeAttributeusing a_derivedTypeIdGUID discriminator field.Added
DerivedTypeDiscriminatorConvention— implementsIDiscriminatorConventionusing_derivedTypeIdas the BSON discriminator field; resolves derived types viaIDerivedTypes.GetDerivedTypeForand falls back to the nominal type when no discriminator is presentMongoDBDefaults.Initialize— iteratesIDerivedTypes.TypesWithDerivativesand registers the convention per base type viaBsonSerializer.RegisterDiscriminatorConvention; no-ops gracefully ifIDerivedTypesis not configuredOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.