Skip to content

Add purchasable extra home slots#11

Open
Yomamaeatstoes wants to merge 2 commits into
CraptiCraft-Development:masterfrom
Inquisitors-transfers:master
Open

Add purchasable extra home slots#11
Yomamaeatstoes wants to merge 2 commits into
CraptiCraft-Development:masterfrom
Inquisitors-transfers:master

Conversation

@Yomamaeatstoes

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reflection usually frowned upon

@Loving11ish

Copy link
Copy Markdown
Member

@Yomamaeatstoes please also remove instances of nested classes as I HATE them from a flow perspective. Please move them to new separate classes in the models package.

If you can just include the Vault API as a soft dependency and remove the reflection access. If you make these changes, then I'm probably very likely accept your PR

@Yomamaeatstoes

Copy link
Copy Markdown
Author

@Yomamaeatstoes please also remove instances of nested classes as I HATE them from a flow perspective. Please move them to new separate classes in the models package.

If you can just include the Vault API as a soft dependency and remove the reflection access. If you make these changes, then I'm probably very likely accept your PR

Done ( :

@Loving11ish

Copy link
Copy Markdown
Member

Many thanks for the alterations. I'll have a detailed run through asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants