fix(two-factor-auth): gate 2FA enforcement on global setting (SER-2911)#7760
Open
coskunaydinoglu wants to merge 1 commit into
Open
fix(two-factor-auth): gate 2FA enforcement on global setting (SER-2911)#7760coskunaydinoglu wants to merge 1 commit into
coskunaydinoglu wants to merge 1 commit into
Conversation
When global 2FA was enabled, every user who logged in was force-enrolled and got two_factor_auth.enabled + secret_token persisted on their member record. After an admin turned global 2FA off, those persisted flags remained, so previously created users were still challenged for 2FA at login (and password reset), while newly created users were not. Make the global setting the single source of truth: login and password reset only enforce 2FA while two-factor-auth.globally_enabled is true. Disabling it now applies to all users regardless of stale per-user flags. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V4HJ5qrPiDme1u8XqcjxqF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.