[star-rating] Load feedback widget assets via document-relative paths#7747
Open
coskunaydinoglu wants to merge 1 commit into
Open
[star-rating] Load feedback widget assets via document-relative paths#7747coskunaydinoglu wants to merge 1 commit into
coskunaydinoglu wants to merge 1 commit into
Conversation
The feedback rating popup is rendered into an iframe by the web SDK and is commonly served behind a reverse proxy mounted on an arbitrary, app-specific sub-folder (e.g. /hr/analytics/). The Countly server has no knowledge of that sub-folder, so emitting asset URLs from the global countlyConfig.path (empty on a root install) produced /star-rating/..., /javascripts/... etc. which resolve against the app origin and 404 behind the proxy. Emit document-relative paths instead, computed per route so they resolve under whatever sub-folder the widget was loaded from: /feedback/rating (two segments) -> ../ /feedback (legacy, one segment) -> '' This also keeps working for plain root installs and installs with a configured countlyConfig.path. Runtime API/logo URLs are unchanged (they already build on the SDK-provided server url). https://claude.ai/code/session_0191WRvHa7axoNxMLPu7xQhk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feedback rating popup is rendered into an iframe by the web SDK and is commonly served behind a reverse proxy mounted on an arbitrary, app-specific sub-folder (e.g. /hr/analytics/). The Countly server has no knowledge of that sub-folder, so emitting asset URLs from the global countlyConfig.path (empty on a root install) produced /star-rating/..., /javascripts/... etc. which resolve against the app origin and 404 behind the proxy.
Emit document-relative paths instead, computed per route so they resolve under whatever sub-folder the widget was loaded from:
/feedback/rating (two segments) -> ../
/feedback (legacy, one segment) -> ''
This also keeps working for plain root installs and installs with a configured countlyConfig.path. Runtime API/logo URLs are unchanged (they already build on the SDK-provided server url).
https://claude.ai/code/session_0191WRvHa7axoNxMLPu7xQhk