fix: preserve error types in WasmKeeper::execute#288
Open
gmanev7 wants to merge 2 commits intoCosmWasm:mainfrom
Open
fix: preserve error types in WasmKeeper::execute#288gmanev7 wants to merge 2 commits intoCosmWasm:mainfrom
gmanev7 wants to merge 2 commits intoCosmWasm:mainfrom
Conversation
The map_err wrapper converted typed contract errors to a formatted string via StdError::msg(), irrevocably losing the concrete error type. This made downcast_ref::<ContractError>() always return None in tests. Remove the wrapper so errors propagate directly from execute_wasm, preserving the original error type for downcasting in test assertions.
Member
|
Hi @gmanev7! |
This updates test assertions to confirm the fix that errors are not being re-wrapped in "Error executing WasmMsg". Also adds a dedicated execute_error_is_not_wrapped test that explicitly documents this contract.
Author
|
Hi @DariuszDepta, Yep, just pushed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map_err wrapper converted typed contract errors to a formatted string via StdError::msg(), irrevocably losing the concrete error type. This made downcast_ref::() always return None in tests.
Remove the wrapper so errors propagate directly from execute_wasm, preserving the original error type for downcasting in test assertions.