fix(reflection): per-section legacy filtering prevents resolved items from being revived (P1+P2) [CLEAN]#595
Conversation
… from being revived (P1+P2) - Add resolvedAt/resolvedBy/resolutionNote metadata to ReflectionItemMetadata - Filter out resolved items from reflection loading (P1 fix) - Per-section legacy filtering to prevent cross-section revival (P2 fix)
jlin53882
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f5a32201d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const invariantLegacyRows = legacyRows.filter(({ metadata }) => | ||
| toStringArray(metadata.invariants).some( | ||
| (line) => !resolvedInvariantTexts.has(normalizeReflectionLineForAggregation(line)) | ||
| ) |
There was a problem hiding this comment.
When unresolvedItemRows is empty, this row-level filter lets any legacy row through if it has at least one unique invariant, but buildInvariantCandidates later emits all invariant lines from that row. In the common case where one legacy row contains both a resolved line and a still-unique line, the resolved line is revived again, which defeats the resolved-item suppression this patch is adding (same pattern exists for derived rows below).
Useful? React with 👍 / 👎.
1 participant
Summary
問題背景 (Issue #447, #483)
當 reflection items 被標記為「已解決」（resolved）後，它們仍然會透過 legacy fallback mechanism 被重新喚醒，導致resolved advice 反復出現。
修復內容
P1 修復：過濾已解決的 items
esolvedAt、
esolvedBy、
esolutionNote 欄位到 ReflectionItemMetadata
esolvedAt !== undefined 的 items
P2 修復：Per-section legacy filtering
變更
測試
所有原有測試通過。