[codex] fix requestDimensions schema sizing and request payload alignment#572
Draft
[codex] fix requestDimensions schema sizing and request payload alignment#572
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #377.
What changed
embedding.requestDimensionsschema and UI metadataembedding.dimensionsas a request-side override by defaultomitDimensionsWhy
PR #377 left the source of truth split in two places:
requestDimensions ?? dimensionsdimensionsThat meant request-side overrides could pass embedder validation while the store schema was still sized from a different value. This PR makes the effective vector dimension calculation shared so local validation, store sizing, and request payload behavior stay aligned.
Impact
embedding.dimensionsremains the internal schema/validation dimensionembedding.requestDimensionsis now the explicit request-side override for providers that support variable output sizesomitDimensionsnow cleanly suppresses request-side dimension fields even whenrequestDimensionsis configuredValidation
node test/embedder-error-hints.test.mjsnode test/plugin-manifest-regression.mjsnpm test