added new test cases #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMistrik
requested changes
Mar 5, 2023
Collaborator
DanielMistrik
left a comment
DanielMistrik
left a comment
There was a problem hiding this comment.
Please address the comments made. Also make sure that the test cases all pass for you and if not address the issues causing the test cases to fail.
src/test/testOrderBook.java
Outdated
| Order newAsk = new Order(10.3f, 1.2f, Side.ASK, 1677538239L); | ||
| testSubject.placeOrder(newAsk); | ||
| // Checking Operation | ||
| assertEquals(1, testSubject.asks.size()); |
Collaborator
There was a problem hiding this comment.
Wouldn't this throw? With three sitting Ask order we would expect the number of ask orders to be 3 not 1
| assertEquals(0, testSubject.bids.size()); | ||
| assertEquals(3.2f, testSubject.asks.getFirst().price); | ||
| assertEquals(0.5f, testSubject.asks.getFirst().size); | ||
| assertEquals(1677539233L, testSubject.asks.getFirst().createdTs); |
Collaborator
There was a problem hiding this comment.
The best ask price (the lower the better) would be 3.2 now.
src/test/testOrderBook.java
Outdated
| assertEquals(10.3f, testSubject.asks.getFirst().price); | ||
| assertEquals(1.2f, testSubject.asks.getFirst().size); | ||
| assertEquals(1677538239L, testSubject.asks.getFirst().createdTs); | ||
| assertEquals(10.3f, testSubject.bestAskPrice); |
Collaborator
There was a problem hiding this comment.
Look at the 2nd comment above.
src/test/testOrderBook.java
Outdated
| Order newBid = new Order(5.3f, 0.3f, Side.BID, 1677598183L); | ||
| testSubject.placeOrder(newBid); | ||
| //Checking Operation | ||
| assertEquals(2, testSubject.asks.size()); |
Collaborator
There was a problem hiding this comment.
Ask size() would be 1, not 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.