2 task 1 implement testorderbook howard #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BidlimitCROSSED, oneBidoneAskFILL, throw exception on CROSSEDMARKET condition
DanielMistrik
requested changes
Mar 5, 2023
Collaborator
DanielMistrik
left a comment
DanielMistrik
left a comment
There was a problem hiding this comment.
I haven't reviewed all of it as it you have some Merge conflcits and I'm not sure whether your iml versions will work on everyone elses set-up (I will test it on my computer and lyk). For the time being try to resolve the merge issues and make sure that everything is working afterwards.
| <root url="jar://$MODULE_DIR$/lib/junit-jupiter-params-5.7.0.jar!/" /> | ||
| <root url="jar://$MODULE_DIR$/lib/junit-jupiter-engine-5.7.0.jar!/" /> | ||
| <root url="jar://$MODULE_DIR$/lib/junit-platform-engine-1.7.0.jar!/" /> | ||
| </CLASSES> |
Collaborator
There was a problem hiding this comment.
I'm not sure whether this will work on other people's computers. Your unique set-up might make this not work on anyone elses. Also try to use Junit 5.7.0, not Junit 5.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: 4 tests cases: oneBidstoplimit, oneAsklimit, twoAskmarketoneBidlimitCROSSED, oneBidoneAskFILL, throw exception on CROSSEDMARKET condition