Eli Test cases #17
Open
Eli Test cases #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 4 test cases, including multiple fills test and a duplicate fills test
Collaborator
|
Please merge with latest branch and check that the test cases are all passing. |
DanielMistrik
requested changes
Mar 4, 2023
Collaborator
DanielMistrik
left a comment
DanielMistrik
left a comment
There was a problem hiding this comment.
Looks good! Just some minor changes and make sure they all pass with the latest main branch! If not please try to fix the issues
changes
Fixed some errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 4 test cases, including multiple fills test and a duplicate fills test.