Skip to content

tictactoe#3

Open
CoreyTyler wants to merge 3 commits intogh-pagesfrom
week3-1
Open

tictactoe#3
CoreyTyler wants to merge 3 commits intogh-pagesfrom
week3-1

Conversation

@CoreyTyler
Copy link
Copy Markdown
Owner

@CoreyTyler CoreyTyler commented Oct 2, 2019

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

yousifS
yousifS reviewed Oct 9, 2019
View reviewed changes
Comment thread 03week/ticTacToe.js Outdated
return true;
} else if (true == verticalWin()) {
return true;
} else if (true == verticalWin()) {
Copy link
Copy Markdown

@yousifS yousifS Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to check for a diagonal win here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yousifS yousifS yousifS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CoreyTyler @yousifS