Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Query Service (server plugin + Studio client plugin) to be compatible with CoreMedia Content Cloud 13 (2512.0.0), including corresponding build/tooling updates.
Changes:
- Update server-side Spring wiring to use
CapConnection/CommonBeansForPluginsConfigurationand adjust Maven BOM/dependencies for CM 2512 + Java 21. - Update Studio client workspace to pnpm catalog-based dependency management and adjust imports for moved CoreMedia client APIs.
- Update GitHub Actions build/release workflows to newer Java/Node/PNPM toolchains and refresh documentation versioning info.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
query-service-lib/src/main/java/com/coremedia/labs/studio/rest/QueryRestConfiguration.java |
Switches to CM13-compatible bean wiring via CapConnection and common plugin beans config. |
query-service-lib/pom.xml |
Bumps plugin version, moves to CM 2512.0.0 BOMs, updates dependencies and build plugins for Java 21. |
pom.xml |
Bumps parent version to 3.0.0-SNAPSHOT. |
docs/README.md |
Updates versioning documentation and adds a compatibility badge. |
apps/studio-client/pnpm-workspace.yaml |
Introduces pnpm catalog entries for CM 2512 package set and tooling. |
apps/studio-client/package.json |
Updates engines/tooling expectations and pnpm package manager metadata. |
apps/studio-client/apps/main/query-studio-plugin/src/app/QueryToolTabBase.ts |
Updates CoreMedia client-core import paths for CM 2512. |
apps/studio-client/apps/main/query-studio-plugin/src/app/QueryResultGridPanelBase.ts |
Updates RemoteService/Logger import paths for CM 2512. |
apps/studio-client/apps/main/query-studio-plugin/src/app/QueryPanelBase.ts |
Replaces removed API usage with getAllContentTypeEntries() from new module. |
apps/studio-client/apps/main/query-studio-plugin/package.json |
Migrates dependencies to catalog: and updates package metadata/scripts. |
.github/workflows/build.yml |
Updates CI toolchain (Java/Node/PNPM), caching, and Maven goal. |
.github/workflows/release.yml |
Updates release toolchain and tagging output handling; adjusts build steps. |
pom.xml.versionsBackup / query-service-lib/pom.xml.versionsBackup |
Removes versions plugin backup files from the repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|  | ||
|
|
There was a problem hiding this comment.
The Markdown image link is broken because the title text spans multiple lines inside the link parentheses. This will render incorrectly (or not at all). Keep the entire image syntax on one line, or move the explanation into a separate paragraph below the badge.
|  | |
|  | |
| Please read the versioning section of the project to see what other CoreMedia versions are supported and how to find them. |
.github/workflows/build.yml
Outdated
| cache: 'maven' | ||
| - name: Cache Maven Repo | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.m2 |
There was a problem hiding this comment.
Maven caching is configured twice: actions/setup-java has cache: 'maven' and there is also an explicit actions/cache step for ~/.m2 right after. This redundancy increases workflow complexity and can cause confusing cache behavior; consider removing one of the two (typically keep setup-java's built-in cache and drop the separate actions/cache step).
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: sbuettne <883798+sbuettne@users.noreply.github.com>
[WIP] WIP: Address feedback on CMCC 13 2512 plugin update PR
Plugin code and build actions updated to CMCC 13 (2512.0.0) compatibility.